Refactor azure hypershift install timers #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morenod
force-pushed
the
control_plane_timers
branch
4 times, most recently
from
b3908c4
to
4384ad0
Compare
mukrishn
reviewed
Oct 7, 2024
| self.logging.error(err) | ||
| time.sleep(1) | ||
| continue | ||
| if any(item["message"] == "The hosted control plane is available" and item["status"] == "True" for item in cluster_status): |
There was a problem hiding this comment.
@morenod This status also reflects kube-apiserver Availability ? or just the hostedcontrolplane custom resource status.
morenod
force-pushed
the
control_plane_timers
branch
2 times, most recently
from
1d7ac0a
to
f437f2a
Compare
morenod
force-pushed
the
control_plane_timers
branch
from
f437f2a
to
5b988b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Description
For every timer, now we xx_total for total time since
hypershift cluster createis launched and xx_delta0 for the time since the previous stage.This is to make dashboard creation easier, following dashboard has been also modified to use new timers
Execution example: https://grafana.rdu2.scalelab.redhat.com:3000/d/tQHfAzyVz/managed-services-install-timings?orgId=1&from=now-12h&to=now&var-datasource=bDQe-DMVz&var-uuid=618d98e5-14c6-4bfa-b5f1-65732efe6d4f&var-install_method=All&var-mgmt_cluster_name=All&var-version=All&var-group_by=uuid.keyword&var-installationpercentile=90
Related Tickets & Documents
Checklist before requesting a review